From 22dc14c8c88faeedff4b8b9425c4407d86b3eab8 Mon Sep 17 00:00:00 2001
From: andre <andre.filipe6@gmail.com>
Date: Fri, 25 Sep 2026 21:44:54 +0100
Subject: [PATCH] refactor(equipa): partilhar _form.php entre create e edit
 (audit 6.8)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

create.php e edit.php tinham os mesmos campos de formulário duplicados
lado a lado. Extrai o markup comum (nome, nascimento, área, estado,
foto, título, aptidões, formações, descrição) para _form.php, seguindo
o padrão já usado em events/ e memberships/. Cada view fica só com a
lógica que lhe é própria (criar vs. carregar registo existente,
upload/validação de foto, título da página, redirect).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---
 views/admin/team/_form.php  | 41 +++++++++++++++++++++++++++++++++++++
 views/admin/team/create.php | 29 +-------------------------
 views/admin/team/edit.php   | 34 +-----------------------------
 3 files changed, 43 insertions(+), 61 deletions(-)
 create mode 100644 views/admin/team/_form.php

diff --git a/views/admin/team/_form.php b/views/admin/team/_form.php
new file mode 100644
index 0000000..cf641e2
--- /dev/null
+++ b/views/admin/team/_form.php
@@ -0,0 +1,41 @@
+<?php
+// Shared team-member form fields, rendered inside the <form> of both create.php and
+// edit.php. Expects:
+//   $data : associative array with every team column (name, birthday, at, status,
+//           description, title, skills, certifications)
+//   $item : the existing row on edit (for the current photo preview), or null
+$item = $item ?? null;
+?>
+<div class="row g-3">
+    <div class="col-md-8"><label class="form-label">Nome <span class="text-danger">*</span></label>
+        <input class="form-control" name="name" required value="<?= htmlspecialchars($data['name'] ?? '') ?>"></div>
+    <div class="col-md-4"><label class="form-label">Nascimento</label>
+        <input type="date" class="form-control" name="birthday" value="<?= htmlspecialchars($data['birthday'] ?? '') ?>"></div>
+    <div class="col-md-4"><label class="form-label">Área</label>
+        <select class="form-select" name="at"><option value="">—</option>
+            <option value="gym" <?= ($data['at'] ?? '') === 'gym' ? 'selected' : '' ?>>Gym</option>
+            <option value="crossfit" <?= ($data['at'] ?? '') === 'crossfit' ? 'selected' : '' ?>>CrossFit</option>
+        </select></div>
+    <div class="col-md-4"><label class="form-label">Estado</label>
+        <select class="form-select" name="status">
+            <option value="ativo" <?= ($data['status'] ?? '') === 'ativo' ? 'selected' : '' ?>>Ativo</option>
+            <option value="inativo" <?= ($data['status'] ?? '') === 'inativo' ? 'selected' : '' ?>>Inativo</option>
+        </select></div>
+    <div class="col-md-4">
+        <label class="form-label">Foto</label>
+        <?php if ($item && !empty($item['photo'])): ?>
+        <div class="mb-2"><img src="<?= base_url('uploads/team/foto/' . $item['photo']) ?>" alt="" style="max-height:80px;border-radius:4px;"></div>
+        <?php endif; ?>
+        <input type="file" class="form-control" name="photo" accept=".jpg,.jpeg,.png,.gif,.webp">
+    </div>
+    <div class="col-12"><label class="form-label">Título</label>
+        <input class="form-control" name="title" maxlength="100" placeholder="ex.: Personal Trainer · Coach CrossFit" value="<?= htmlspecialchars($data['title'] ?? '') ?>">
+        <div class="form-text">Aparece no site por baixo do nome.</div></div>
+    <div class="col-md-6"><label class="form-label">Aptidões / Funções</label>
+        <textarea class="form-control" name="skills" rows="5" placeholder="Uma por linha"><?= htmlspecialchars($data['skills'] ?? '') ?></textarea></div>
+    <div class="col-md-6"><label class="form-label">Formações</label>
+        <textarea class="form-control" name="certifications" rows="5" placeholder="Uma por linha"><?= htmlspecialchars($data['certifications'] ?? '') ?></textarea></div>
+    <div class="col-12"><div class="form-text mt-0">Aptidões e formações aparecem no cartão de detalhe do site (hover no computador, toque no telemóvel).</div></div>
+    <div class="col-12"><label class="form-label">Descrição <span class="text-muted small">(opcional — aparece no cartão de detalhe)</span></label>
+        <textarea class="form-control js-wysiwyg" data-wysiwyg-height="200" name="description" rows="3"><?= htmlspecialchars($data['description'] ?? '') ?></textarea></div>
+</div>
diff --git a/views/admin/team/create.php b/views/admin/team/create.php
index bd78781..c54f3e1 100644
--- a/views/admin/team/create.php
+++ b/views/admin/team/create.php
@@ -58,34 +58,7 @@ include __DIR__ . '/../../../includes/header.php';
 
     <form method="POST" enctype="multipart/form-data" class="card shadow-sm"><div class="card-body">
         <?= csrf_field() ?>
-        <div class="row g-3">
-            <div class="col-md-8"><label class="form-label">Nome <span class="text-danger">*</span></label>
-                <input class="form-control" name="name" required value="<?= htmlspecialchars($data['name']) ?>"></div>
-            <div class="col-md-4"><label class="form-label">Nascimento</label>
-                <input type="date" class="form-control" name="birthday" value="<?= htmlspecialchars($data['birthday']) ?>"></div>
-            <div class="col-md-4"><label class="form-label">Área</label>
-                <select class="form-select" name="at"><option value="">—</option>
-                    <option value="gym" <?= $data['at'] === 'gym' ? 'selected' : '' ?>>Gym</option>
-                    <option value="crossfit" <?= $data['at'] === 'crossfit' ? 'selected' : '' ?>>CrossFit</option>
-                </select></div>
-            <div class="col-md-4"><label class="form-label">Estado</label>
-                <select class="form-select" name="status">
-                    <option value="ativo" <?= $data['status'] === 'ativo' ? 'selected' : '' ?>>Ativo</option>
-                    <option value="inativo" <?= $data['status'] === 'inativo' ? 'selected' : '' ?>>Inativo</option>
-                </select></div>
-            <div class="col-md-4"><label class="form-label">Foto</label>
-                <input type="file" class="form-control" name="photo" accept=".jpg,.jpeg,.png,.gif,.webp"></div>
-            <div class="col-12"><label class="form-label">Título</label>
-                <input class="form-control" name="title" maxlength="100" placeholder="ex.: Personal Trainer · Coach CrossFit" value="<?= htmlspecialchars($data['title'] ?? '') ?>">
-                <div class="form-text">Aparece no site por baixo do nome.</div></div>
-            <div class="col-md-6"><label class="form-label">Aptidões / Funções</label>
-                <textarea class="form-control" name="skills" rows="5" placeholder="Uma por linha"><?= htmlspecialchars($data['skills'] ?? '') ?></textarea></div>
-            <div class="col-md-6"><label class="form-label">Formações</label>
-                <textarea class="form-control" name="certifications" rows="5" placeholder="Uma por linha"><?= htmlspecialchars($data['certifications'] ?? '') ?></textarea></div>
-            <div class="col-12"><div class="form-text mt-0">Aptidões e formações aparecem no cartão de detalhe do site (hover no computador, toque no telemóvel).</div></div>
-            <div class="col-12"><label class="form-label">Descrição <span class="text-muted small">(opcional — aparece no cartão de detalhe)</span></label>
-                <textarea class="form-control js-wysiwyg" data-wysiwyg-height="200" name="description" rows="3"><?= htmlspecialchars($data['description']) ?></textarea></div>
-        </div>
+        <?php include __DIR__ . '/_form.php'; ?>
         <div class="mt-4 d-flex gap-2">
             <button type="submit" class="btn btn-primary">Guardar</button>
             <a class="btn btn-outline-secondary" href="index.php">Cancelar</a>
diff --git a/views/admin/team/edit.php b/views/admin/team/edit.php
index cde3b23..c642138 100644
--- a/views/admin/team/edit.php
+++ b/views/admin/team/edit.php
@@ -75,39 +75,7 @@ include __DIR__ . '/../../../includes/header.php';
 
     <form method="POST" enctype="multipart/form-data" class="card shadow-sm"><div class="card-body">
         <?= csrf_field() ?>
-        <div class="row g-3">
-            <div class="col-md-8"><label class="form-label">Nome <span class="text-danger">*</span></label>
-                <input class="form-control" name="name" required value="<?= htmlspecialchars($data['name'] ?? '') ?>"></div>
-            <div class="col-md-4"><label class="form-label">Nascimento</label>
-                <input type="date" class="form-control" name="birthday" value="<?= htmlspecialchars($data['birthday'] ?? '') ?>"></div>
-            <div class="col-md-4"><label class="form-label">Área</label>
-                <select class="form-select" name="at"><option value="">—</option>
-                    <option value="gym" <?= ($data['at'] ?? '') === 'gym' ? 'selected' : '' ?>>Gym</option>
-                    <option value="crossfit" <?= ($data['at'] ?? '') === 'crossfit' ? 'selected' : '' ?>>CrossFit</option>
-                </select></div>
-            <div class="col-md-4"><label class="form-label">Estado</label>
-                <select class="form-select" name="status">
-                    <option value="ativo" <?= ($data['status'] ?? '') === 'ativo' ? 'selected' : '' ?>>Ativo</option>
-                    <option value="inativo" <?= ($data['status'] ?? '') === 'inativo' ? 'selected' : '' ?>>Inativo</option>
-                </select></div>
-            <div class="col-md-4">
-                <label class="form-label">Foto</label>
-                <?php if (!empty($item['photo'])): ?>
-                <div class="mb-2"><img src="<?= base_url('uploads/team/foto/' . $item['photo']) ?>" alt="" style="max-height:80px;border-radius:4px;"></div>
-                <?php endif; ?>
-                <input type="file" class="form-control" name="photo" accept=".jpg,.jpeg,.png,.gif,.webp">
-            </div>
-            <div class="col-12"><label class="form-label">Título</label>
-                <input class="form-control" name="title" maxlength="100" placeholder="ex.: Personal Trainer · Coach CrossFit" value="<?= htmlspecialchars($data['title'] ?? '') ?>">
-                <div class="form-text">Aparece no site por baixo do nome.</div></div>
-            <div class="col-md-6"><label class="form-label">Aptidões / Funções</label>
-                <textarea class="form-control" name="skills" rows="5" placeholder="Uma por linha"><?= htmlspecialchars($data['skills'] ?? '') ?></textarea></div>
-            <div class="col-md-6"><label class="form-label">Formações</label>
-                <textarea class="form-control" name="certifications" rows="5" placeholder="Uma por linha"><?= htmlspecialchars($data['certifications'] ?? '') ?></textarea></div>
-            <div class="col-12"><div class="form-text mt-0">Aptidões e formações aparecem no cartão de detalhe do site (hover no computador, toque no telemóvel).</div></div>
-            <div class="col-12"><label class="form-label">Descrição <span class="text-muted small">(opcional — aparece no cartão de detalhe)</span></label>
-                <textarea class="form-control js-wysiwyg" data-wysiwyg-height="200" name="description" rows="3"><?= htmlspecialchars($data['description'] ?? '') ?></textarea></div>
-        </div>
+        <?php include __DIR__ . '/_form.php'; ?>
         <div class="mt-4 d-flex gap-2">
             <button type="submit" class="btn btn-primary">Atualizar</button>
             <a class="btn btn-outline-secondary" href="index.php">Cancelar</a>