From 33b7f19d157e62af6b93900d2cfd0674dcce2500 Mon Sep 17 00:00:00 2001
From: andre <andre.filipe6@gmail.com>
Date: Fri, 25 Sep 2026 21:45:04 +0100
Subject: [PATCH] refactor(horario): partilhar _form.php entre create e edit
 (audit 6.8)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Extrai os campos comuns (modalidade, dia, início, fim, sala) para
_form.php. create.php formatava hora_inicio/hora_fim sem substr()
enquanto edit.php aplicava substr(..., 0, 5) para cortar os segundos
que vêm da coluna TIME da BD — unificado na versão de edit.php (mais
defensiva; sem efeito em create.php, cujos valores já vêm em "HH:MM").

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---
 views/admin/horario/_form.php  | 35 ++++++++++++++++++++++++++++++++++
 views/admin/horario/create.php | 27 +-------------------------
 views/admin/horario/edit.php   | 27 +-------------------------
 3 files changed, 37 insertions(+), 52 deletions(-)
 create mode 100644 views/admin/horario/_form.php

diff --git a/views/admin/horario/_form.php b/views/admin/horario/_form.php
new file mode 100644
index 0000000..477358a
--- /dev/null
+++ b/views/admin/horario/_form.php
@@ -0,0 +1,35 @@
+<?php
+// Shared horário (class-schedule) form fields, rendered inside the <form> of both
+// create.php and edit.php. Expects:
+//   $data        : associative array with every horario column (id_modalidade,
+//                  dia_semana, hora_inicio, hora_fim, local)
+//   $modalidades : rows from db_modalidades_options($pdo)
+//   $dias        : dia_semana value => label map
+//   $salas       : local value => label map
+?>
+<div class="row g-3">
+    <div class="col-12"><label class="form-label">Modalidade <span class="text-danger">*</span></label>
+        <select class="form-select" name="id_modalidade" required>
+            <option value="">Selecionar…</option>
+            <?php foreach ($modalidades as $m): ?>
+            <option value="<?= $m['m_id'] ?>" <?= ($data['id_modalidade'] ?? 0) == $m['m_id'] ? 'selected' : '' ?>><?= htmlspecialchars($m['nome']) ?></option>
+            <?php endforeach; ?>
+        </select></div>
+    <div class="col-md-4"><label class="form-label">Dia <span class="text-danger">*</span></label>
+        <select class="form-select" name="dia_semana" required>
+            <option value="">Selecionar…</option>
+            <?php foreach ($dias as $val => $label): ?>
+            <option value="<?= $val ?>" <?= ($data['dia_semana'] ?? '') === $val ? 'selected' : '' ?>><?= $label ?></option>
+            <?php endforeach; ?>
+        </select></div>
+    <div class="col-md-4"><label class="form-label">Início <span class="text-danger">*</span></label>
+        <input type="time" class="form-control" name="hora_inicio" required value="<?= htmlspecialchars(substr($data['hora_inicio'] ?? '09:00', 0, 5)) ?>"></div>
+    <div class="col-md-4"><label class="form-label">Fim <span class="text-danger">*</span></label>
+        <input type="time" class="form-control" name="hora_fim" required value="<?= htmlspecialchars(substr($data['hora_fim'] ?? '10:00', 0, 5)) ?>"></div>
+    <div class="col-12"><label class="form-label">Sala</label>
+        <select class="form-select" name="local">
+            <?php foreach ($salas as $val => $label): ?>
+            <option value="<?= $val ?>" <?= ($data['local'] ?? '') === $val ? 'selected' : '' ?>><?= $label ?></option>
+            <?php endforeach; ?>
+        </select></div>
+</div>
diff --git a/views/admin/horario/create.php b/views/admin/horario/create.php
index bb4d2aa..643a90f 100644
--- a/views/admin/horario/create.php
+++ b/views/admin/horario/create.php
@@ -41,32 +41,7 @@ include __DIR__ . '/../../../includes/header.php';
 
     <form method="POST" class="card shadow-sm"><div class="card-body">
         <?= csrf_field() ?>
-        <div class="row g-3">
-            <div class="col-12"><label class="form-label">Modalidade <span class="text-danger">*</span></label>
-                <select class="form-select" name="id_modalidade" required>
-                    <option value="">Selecionar…</option>
-                    <?php foreach ($modalidades as $m): ?>
-                    <option value="<?= $m['m_id'] ?>" <?= $data['id_modalidade'] == $m['m_id'] ? 'selected' : '' ?>><?= htmlspecialchars($m['nome']) ?></option>
-                    <?php endforeach; ?>
-                </select></div>
-            <div class="col-md-4"><label class="form-label">Dia <span class="text-danger">*</span></label>
-                <select class="form-select" name="dia_semana" required>
-                    <option value="">Selecionar…</option>
-                    <?php foreach ($dias as $val => $label): ?>
-                    <option value="<?= $val ?>" <?= $data['dia_semana'] === $val ? 'selected' : '' ?>><?= $label ?></option>
-                    <?php endforeach; ?>
-                </select></div>
-            <div class="col-md-4"><label class="form-label">Início <span class="text-danger">*</span></label>
-                <input type="time" class="form-control" name="hora_inicio" required value="<?= htmlspecialchars($data['hora_inicio']) ?>"></div>
-            <div class="col-md-4"><label class="form-label">Fim <span class="text-danger">*</span></label>
-                <input type="time" class="form-control" name="hora_fim" required value="<?= htmlspecialchars($data['hora_fim']) ?>"></div>
-            <div class="col-12"><label class="form-label">Sala</label>
-                <select class="form-select" name="local">
-                    <?php foreach ($salas as $val => $label): ?>
-                    <option value="<?= $val ?>" <?= $data['local'] === $val ? 'selected' : '' ?>><?= $label ?></option>
-                    <?php endforeach; ?>
-                </select></div>
-        </div>
+        <?php include __DIR__ . '/_form.php'; ?>
         <div class="mt-4 d-flex gap-2">
             <button type="submit" class="btn btn-primary">Guardar</button>
             <a class="btn btn-outline-secondary" href="index.php">Cancelar</a>
diff --git a/views/admin/horario/edit.php b/views/admin/horario/edit.php
index 88185ed..ada8f7a 100644
--- a/views/admin/horario/edit.php
+++ b/views/admin/horario/edit.php
@@ -51,32 +51,7 @@ include __DIR__ . '/../../../includes/header.php';
 
     <form method="POST" class="card shadow-sm"><div class="card-body">
         <?= csrf_field() ?>
-        <div class="row g-3">
-            <div class="col-12"><label class="form-label">Modalidade <span class="text-danger">*</span></label>
-                <select class="form-select" name="id_modalidade" required>
-                    <option value="">Selecionar…</option>
-                    <?php foreach ($modalidades as $m): ?>
-                    <option value="<?= $m['m_id'] ?>" <?= ($data['id_modalidade'] ?? 0) == $m['m_id'] ? 'selected' : '' ?>><?= htmlspecialchars($m['nome']) ?></option>
-                    <?php endforeach; ?>
-                </select></div>
-            <div class="col-md-4"><label class="form-label">Dia <span class="text-danger">*</span></label>
-                <select class="form-select" name="dia_semana" required>
-                    <option value="">Selecionar…</option>
-                    <?php foreach ($dias as $val => $label): ?>
-                    <option value="<?= $val ?>" <?= ($data['dia_semana'] ?? '') === $val ? 'selected' : '' ?>><?= $label ?></option>
-                    <?php endforeach; ?>
-                </select></div>
-            <div class="col-md-4"><label class="form-label">Início <span class="text-danger">*</span></label>
-                <input type="time" class="form-control" name="hora_inicio" required value="<?= htmlspecialchars(substr($data['hora_inicio'] ?? '09:00', 0, 5)) ?>"></div>
-            <div class="col-md-4"><label class="form-label">Fim <span class="text-danger">*</span></label>
-                <input type="time" class="form-control" name="hora_fim" required value="<?= htmlspecialchars(substr($data['hora_fim'] ?? '10:00', 0, 5)) ?>"></div>
-            <div class="col-12"><label class="form-label">Sala</label>
-                <select class="form-select" name="local">
-                    <?php foreach ($salas as $val => $label): ?>
-                    <option value="<?= $val ?>" <?= ($data['local'] ?? '') === $val ? 'selected' : '' ?>><?= $label ?></option>
-                    <?php endforeach; ?>
-                </select></div>
-        </div>
+        <?php include __DIR__ . '/_form.php'; ?>
         <div class="mt-4 d-flex gap-2">
             <button type="submit" class="btn btn-primary">Atualizar</button>
             <a class="btn btn-outline-secondary" href="index.php">Cancelar</a>